New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless loop in personal page #4948

Closed

LukasReschke opened this issue May 18, 2017 · 4 comments

Labels

high regression

Milestone

Member

LukasReschke commented May 18, 2017

Can't open the personal page as there seems to be an endless loop, I decreased the timeout to 30 seconds to get at least an error log entry:

[Thu May 18 23:44:42.928818 2017] [:error] [pid 29639] [client XXXX:49646] PHP Fatal error: Maximum execution time of 30 seconds exceeded in /var/www/html/lib/private/Template/ResourceLocator.php on line 149

LukasReschke added high regression labels

LukasReschke added this to the Nextcloud 12.0 milestone

Member Author

LukasReschke commented May 18, 2017

Code in question https://github.com/nextcloud/server/blob/v12.0.0RC1/lib/private/Template/ResourceLocator.php#L132-L150

Member Author

LukasReschke commented May 18, 2017 •

edited

Loading

$tmpRoot is an empty string on the system.

Member Author

LukasReschke commented May 18, 2017

This is caused by @schiessle's auto-replace of the string "authtoken" with "AuthToken", if I change

server/settings/personal.php

Line 52 in 44c9080

OC_Util::addScript('settings', 'AuthToken');

back then it works. Anyhow, we should in no case run in an endless loop just because a file is otherwise cased on the system…

LukasReschke added a commit that referenced this issue


          Lowercase the scriptname again

54b2286

Ref #4948

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

LukasReschke mentioned this issue

Lowercase the scriptname again #4949

Merged

LukasReschke added a commit that referenced this issue


          Lowercase the scriptname again

eab9468

Ref #4948

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

LukasReschke mentioned this issue

Lowercase the scriptname again #4950

Merged

Member Author

LukasReschke commented May 19, 2017

I have "patches" at #4949 and #4950. But I'd appreciate if somebody could also look into the issue why we end up in an endless loop if a resource cannot be found. This endless loop consumed a whole CPU alone…

nickvergessen mentioned this issue

Stop infinit loop on invalid settings css/js file #4956

Merged

rullzer closed this as completed in #4956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment