Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch logcondition earlier #10451

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Fetch logcondition earlier #10451

merged 1 commit into from
Jul 30, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jul 30, 2018

Fixes #9693

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Fetch logcondition earlier
8cdd134 
Fixes #9693

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Jul 30, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Jul 30, 2018
nickvergessen
nickvergessen approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

juliushaertl
juliushaertl approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 30, 2018
@rullzer rullzer merged commit 1f610b4 into master Jul 30, 2018
@rullzer rullzer deleted the fix/9693/move_logcondition_up branch July 30, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @nickvergessen @juliushaertl