Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that user search is in progress #10531 #10532

Closed
wants to merge 1 commit into from
Closed

Show that user search is in progress #10531 #10532

wants to merge 1 commit into from

Conversation

fgsl
Copy link

@fgsl fgsl commented Aug 3, 2018

  • During the processing of the research, there is no indication that the research is being processed.
  • For a backend with thousands of users, this can generate doubts to user about the processing.

- During the processing of the research, there is no indication that
the research is being processed.
- For a backend with thousands of users, this can generate doubts to
user about the processing.
@ChristophWurst
Copy link
Member

I'm very sorry that nobody noticed this PR.

I checked the existing code and that already updates the UI accordingly during the search:

if (_.isUndefined(searchTerm) || searchTerm === '') {
self._view.showLoading(t('core', 'Loading your contacts …'));
} else {
self._view.showLoading(t('core', 'Looking for {term} …', {
term: searchTerm
}));
}
.

Therefore I'm closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants