Comment mentions with spaces

[nickvergessen]

1. Create a user with a space in the user id: foo bar
2. Share a file with the user
3. Mention the user using autocompletion
4. Look at the message

Before: Hi {{@Unknown user}} bar test
After: Hi {{@User with space in ID}} test

Fix #2443

[nickvergessen]

The problem at the moment is, that the " is a word seperator, and therefor the regex does not match anymore, as the \b is not there:

server/apps/comments/js/commentstabview.js

Lines 424 to 430 in 52723f0

	// replace every mention either at the start of the input or after a whitespace
	// followed by a non-word character.
	message = message.replace(new RegExp("(^|\\s)(" + mention + ")\\b", 'g'),
	function(match, p1) {
	// to get number of whitespaces (0 vs 1) right
	return p1+displayName;
	}

In Talk we do the replacement in php with a simple str_replace and therefor do not have this problem.

So my idea would be to screw the word end check for quoted user ids.

[blizzz]

Would you mind adding another test case to \Test\Comments\CommentTest::mentionsProvider() that supports the uid-with-space-scenario?

Otherwise, the code looks good and i like the simplicity

[blizzz]

Imho this style is rather confusing than improving readability. Might be just me tho.

[MorrisJobke]

https://github.com/nextcloud/server/pull/11836/files?ts=4#diff-07287428c5872cf7258d96b38fb1237eR609 I think it's fine 👍

[nickvergessen]

Otherwise, the code looks good and i like the simplicity

I wanted to here this, before diving into tests, because if we don't agree on @"…" I dont waste time on the tests. So will do now.

[MorrisJobke]

Even after rebase of this branch the user is not properly shown:

I used foo bar

[nickvergessen]

@MorrisJobke this is not retro-active, because the saved comment is different (old: @foo bar new: @"foo bar"). Did you create a new comment and use the autocompletion for it?

[nickvergessen]

Added a unit test and rebased.

still working for me, so ready for review.

[MorrisJobke]

@MorrisJobke this is not retro-active, because the saved comment is different (old: @foo bar new: @"foo bar"). Did you create a new comment and use the autocompletion for it?

Ah - I created the comment first and then changed the branch. Let me test again.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

Unrelated trash bin failure -> merge