Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP: announce display name changes so that addressbook picks it up #12054

Merged
merged 2 commits into from
Oct 30, 2018
Merged

LDAP: announce display name changes so that addressbook picks it up #12054

merged 2 commits into from
Oct 30, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Oct 25, 2018

fixes #9112 (and refs #5212)

Test is:

  1. Have LDAP enabled and configured
  2. Ensure User A and B show up on users page
  3. As User A (or admin, does not matter), look up User B in the contacts menu on the upper right
  4. Change the displayName of User B in LDAP
  5. Log in as User B to ensure the displayname is fetched from LDAP and updated
  6. Again as User A look up User B again.

Now the new displayname should be presented, previously it did not.

@nextcloud/ldap

@blizzz
only write when the displayname differs, but then announce it
bbe4410 
refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 15 milestone Oct 25, 2018
@blizzz blizzz mentioned this pull request Oct 25, 2018
Closed
MorrisJobke
MorrisJobke approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@blizzz
Copy link
Member Author

blizzz commented Oct 26, 2018 •
edited
Loading

Causes Doctrine\\DBAL\\Exception\\UniqueConstraintViolationException","Message":"An exception occurred while executing 'INSERT INTO \"oc_accounts\" on the integratiion test, just … how and why? Cannot reproduce it locally.

UPDATE: I have a plausible theory now. This is corndered by some setup bits: 5 tables should not contain data about the certain user, cron mode must be ajax and no memcache must be set up. could reproduce.

@blizzz blizzz added 2. developing Work in progress 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 2. developing Work in progress labels Oct 26, 2018
@blizzz
Copy link
Member Author

blizzz commented Oct 26, 2018 •
edited
Loading

Should do now. Happy about the integration tests catching this beast :)

@rullzer
Copy link
Member

rullzer commented Oct 29, 2018

CI is not happy

@blizzz
do not run into UniqueConstraintViolationException
49456e4 
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/5212/interact-with-userobject branch from 9adf542 to 49456e4 Compare October 30, 2018 11:12
@blizzz
Copy link
Member Author

blizzz commented Oct 30, 2018

Indeed, I missed to adjust the tests with the last commit.

@rullzer rullzer merged commit 8b2b238 into master Oct 30, 2018
@rullzer rullzer deleted the fix/5212/interact-with-userobject branch October 30, 2018 12:38
@blizzz blizzz mentioned this pull request Oct 30, 2018
Closed
blizzz added a commit that referenced this pull request Oct 30, 2018
@blizzz
Backport of #12054 to stable14
bdb8e37 
only write when the displayname differs, but then announce it

refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

do not run into UniqueConstraintViolationException

… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz mentioned this pull request Oct 30, 2018
Merged
blizzz added a commit that referenced this pull request Oct 30, 2018
@blizzz
Backport of #12054 to stable13
908e6be 
only write when the displayname differs, but then announce it

refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

do not run into UniqueConstraintViolationException

… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz mentioned this pull request Oct 30, 2018
Merged
@blizzz blizzz mentioned this pull request Nov 1, 2018
Closed
@fflorent fflorent mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@GitHubUser4234 GitHubUser4234 Awaiting requested review from GitHubUser4234

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: ldap
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.

Nextcloud 13: User changes do not get displayed
3 participants
@blizzz @rullzer @MorrisJobke