-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sharees via propfind #14429
Merged
Merged
Show sharees via propfind #14429
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e3991fb
Show sharees via propfind
tobiasKaminsky b81fb18
wip
tobiasKaminsky efa0733
wip
tobiasKaminsky 06a9ade
Use proper caching
rullzer 2a45763
Use proper ShareeList
rullzer 21477bc
Unify share fetching
rullzer 42f00e8
add display name to sharee list
tobiasKaminsky 85d5400
Fix tests
rullzer 82ae6fb
use namespace everywhere
tobiasKaminsky eb564e8
get all shares, not only first one per type
tobiasKaminsky a853926
Fix tests
rullzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
<?php | ||
declare(strict_types=1); | ||
/** | ||
* @copyright Copyright (c) 2019, Roeland Jago Douma <roeland@famdouma.nl> | ||
* | ||
* @author Roeland Jago Douma <roeland@famdouma.nl> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace OCA\DAV\Connector\Sabre; | ||
|
||
use OCP\Share\IShare; | ||
use Sabre\Xml\Element; | ||
use Sabre\Xml\Reader; | ||
use Sabre\Xml\Writer; | ||
use Sabre\Xml\XmlSerializable; | ||
|
||
/** | ||
* This property contains multiple "sharee" elements, each containing a share sharee | ||
*/ | ||
class ShareeList implements XmlSerializable { | ||
const NS_NEXTCLOUD = 'http://nextcloud.org/ns'; | ||
|
||
/** @var IShare[] */ | ||
private $shares; | ||
|
||
public function __construct(array $shares) { | ||
$this->shares = $shares; | ||
} | ||
|
||
/** | ||
* The xmlSerialize metod is called during xml writing. | ||
* | ||
* @param Writer $writer | ||
* @return void | ||
*/ | ||
function xmlSerialize(Writer $writer) { | ||
foreach ($this->shares as $share) { | ||
$writer->startElement('{' . self::NS_NEXTCLOUD . '}sharee'); | ||
$writer->writeElement('{' . self::NS_NEXTCLOUD . '}id', $share->getSharedWith()); | ||
$writer->writeElement('{' . self::NS_NEXTCLOUD . '}display-name', $share->getSharedWithDisplayName()); | ||
$writer->writeElement('{' . self::NS_NEXTCLOUD . '}type', $share->getShareType()); | ||
$writer->endElement(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote a test for android library and there the problem also exists.
It seems that always one of the display names is set to userId.