Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony's new contract Event class instead of the deprecated one #17085

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

ChristophWurst
Copy link
Member

Leftover from the 4.3 bump at #17049.

Fixes the

deprecated the Event class, use Symfony\Contracts\EventDispatcher\Event instead

deprecation for the new event dispatcher system. In theory this could be a breaking change as apps might have used methods of the old base class, but the likelihood is very low IMO.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable IMO.

@ChristophWurst
Copy link
Member Author

This now includes the changes from #17084 as dispatch would otherwise do 💥 if it detects the usage of the new event base class.

@nickvergessen
Copy link
Member

Which methods are affected? isPropagationStopped and stopPropagation?
If so sharing and talk chat message parsing are affected

@ChristophWurst
Copy link
Member Author

Do they use Symfony directly or our abstraction?

@rullzer
Copy link
Member

rullzer commented Sep 10, 2019

Both functions are still there.

@rullzer
Copy link
Member

rullzer commented Sep 10, 2019

Which methods are affected? isPropagationStopped and stopPropagation?
If so sharing and talk chat message parsing are affected

Also note that it is only for things that use the new event stuff. So talk is not affected right now.

@blizzz blizzz mentioned this pull request Sep 11, 2019
16 tasks
@ChristophWurst
Copy link
Member Author

Pushed another commit. 🤞 this makes our tests happy. Apparently we ran into a form of the fragile base class problem. Yay.

@rullzer
Copy link
Member

rullzer commented Sep 12, 2019

rebase

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/symfony-event-dispatcher-contracts-events branch from e982b4d to a1ef939 Compare September 12, 2019 12:45
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 12, 2019
@blizzz blizzz merged commit 89d3b2c into master Sep 14, 2019
@blizzz blizzz deleted the refactor/symfony-event-dispatcher-contracts-events branch September 14, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants