Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Make sure the UID is correctly cased #1770

Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 17, 2016

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Oct 17, 2016
@nickvergessen nickvergessen added this to the Nextcloud 9.0.55 milestone Oct 17, 2016
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 and @carlaschroder to be potential reviewers.

@MorrisJobke
Copy link
Member

I tested this and it only works with lower case user names. If I try ./occ files:transfer-ownership Test1 Test it still shows the wrong casing:

Analysing files of Test1 ...
    1 [============================]
Collecting all share information for files and folder of Test1 ...
    0 [>---------------------------]
Transferring files to Test2/files/transferred from Test1 on 2016-10-17T15:45:28+00:00 ...
Restoring shares ...
    0 [>---------------------------]

@MorrisJobke
Copy link
Member

If I try ./occ files:transfer-ownership Test1 Test it still shows the wrong casing:

to clarify: The user names are lower case in Nextcloud. The files are not transfered and the output also shows the reason: the casing is somehow still wrong.

… differs in case sensitivity

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Added backport of #1142 now it works.

@MorrisJobke
Copy link
Member

Tested and works now 👍

cc @rullzer please review

@rullzer
Copy link
Member

rullzer commented Oct 24, 2016

Yep.
LGTM!

@rullzer rullzer merged commit eb47c20 into stable9 Oct 24, 2016
@rullzer rullzer deleted the backport-1766-force-uid-casing-on-transfer-ownership-9 branch October 24, 2016 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants