Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset the list after adding cached entries #1771

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

nickvergessen
Copy link
Member

Steps

  1. Create access control rule 1:
    • File system tag - is tagged with - test
    • User group membership - is member of - group
  2. Create access control rule 2:
    • File system tag - is tagged with - test
    • User group membership - is not ❗️ member of - group
  3. Refresh the page

Expected

Rule 1:

  • File system tag - is tagged with - test
  • User group membership - is member of - group
    Rule 2:
  • File system tag - is tagged with - test
  • User group membership - is not member of - group

Actual

Rule 1:

  • File system tag - is tagged with - test
  • User group membership - is member of - group
    Rule 2:
  • User group membership - is not member of - group

Found while looking into https://help.nextcloud.com/t/files-access-control-issue-with-browsing-folders/3608/3

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke to be a potential reviewer.

@nickvergessen
Copy link
Member Author

Let me write unit tests for this

Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke
Copy link
Member

Tested and works 👍

@codecov-io
Copy link

Current coverage is 57.32% (diff: 100%)

Merging #1771 into master will increase coverage by 0.05%

@@             master      #1771   diff @@
==========================================
  Files          1075       1075          
  Lines         61278      61291    +13   
  Methods        6864       6864          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          35092      35134    +42   
+ Misses        26186      26157    -29   
  Partials          0          0          

Sunburst

Diff Coverage File Path
•••••••••• 100% apps/workflowengine/lib/Manager.php

Powered by Codecov. Last update 6375790...4d6ec43

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke merged commit 9759f55 into master Oct 18, 2016
@LukasReschke LukasReschke deleted the fix-issue-loading-checks-from-cache branch October 18, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants