Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typed events for all group hooks and legacy events #18322

Closed
wants to merge 2 commits into from
Closed

Add typed events for all group hooks and legacy events #18322

wants to merge 2 commits into from

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 10, 2019 •
edited
Loading

Continuation of #18225

  • Add typed events
  • Emit events where we emitted legacy events and/or hooks
  • Catch new events and re-emit data as legacy events and/or hooks
  • preAddUser (\OC\Group\Group $group, \OC\User\User $user)
  • postAddUser (\OC\Group\Group $group, \OC\User\User $user)
  • preRemoveUser (\OC\Group\Group $group, \OC\User\User $user)
  • postRemoveUser (\OC\Group\Group $group, \OC\User\User $user)
  • preDelete (\OC\Group\Group $group)
  • postDelete (\OC\Group\Group $group)
  • preCreate (string $groupId)
  • postCreate (\OC\Group\Group $group)

-> existing code should continue to work, but new code can use the typed events with 18+

@ChristophWurst
Add typed events for all group hooks and legacy events
5bf119b 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 10, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 10, 2019
@ChristophWurst
fixup! Add typed events for all group hooks and legacy events
b52a8d5 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
@ChristophWurst ChristophWurst mentioned this pull request Dec 11, 2019
Merged
@ChristophWurst ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Dec 11, 2019
@ChristophWurst ChristophWurst removed this from the Nextcloud 18 milestone Dec 11, 2019
@ChristophWurst ChristophWurst mentioned this pull request Dec 11, 2019
Merged
@ChristophWurst
Copy link
Member Author

Integrated as #18350. The clean up has to be done on a french branch, I guess

@ChristophWurst ChristophWurst deleted the enhancement/typed-group-events branch March 6, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChristophWurst ChristophWurst

Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: users and groups technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChristophWurst