Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dav setting for user's default calendar #19852

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Mar 8, 2020

And add tests to handle schedule-default-calendar-URL

Part 1 for #19826

@tcitworld tcitworld added 3. to review Waiting for reviews feature: dav labels Mar 8, 2020
@tcitworld tcitworld added this to the Nextcloud 19 milestone Mar 8, 2020
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from 6867a83 to 229fb7a Compare March 8, 2020 17:23
@georgehrke
Copy link
Member

Just double checked to make sure:
The dav property is a protected one: https://github.com/nextcloud/3rdparty/blob/master/sabre/dav/lib/CalDAV/Schedule/Plugin.php#L129

@georgehrke
Copy link
Member

@tcitworld What is your concept for the endpoint for setting this?
Some DAV method or just a Controller endpoint?

@tcitworld
Copy link
Member Author

Since the property was read-only in Sabre I only thought of it at first as a Controller endpoint. We could indeed do that through a DAV method, but is it worth it anyway? Does macOS/iOS Calendar handle this?

@georgehrke
Copy link
Member

No, the only two interesting things you can configure via DAV in macOS are default alarms for timed events and allday events:

<A:propertyupdate xmlns:A="DAV:">
	<A:set>
		<A:prop>
			<B:default-alarm-vevent-datetime xmlns:B="urn:ietf:params:xml:ns:caldav">
				<![CDATA[BEGIN:VALARM
				X-WR-ALARMUID:7254E71A-A1F6-41F5-A006-1B435D9B78E3
				UID:7254E71A-A1F6-41F5-A006-1B435D9B78E3
				TRIGGER:-PT30M
				ATTACH;VALUE=URI:Chord
				ACTION:AUDIO
				END:VALARM
				]]>
			</B:default-alarm-vevent-datetime>
		</A:prop>
	</A:set>
</A:propertyupdate>
<A:propertyupdate xmlns:A="DAV:">
	<A:set>
		<A:prop>
			<B:default-alarm-vevent-date xmlns:B="urn:ietf:params:xml:ns:caldav">
				<![CDATA[BEGIN:VALARM
				X-WR-ALARMUID:659B19ED-7E2B-427A-9ABA-973206876796
				UID:659B19ED-7E2B-427A-9ABA-973206876796
				TRIGGER:-P1DT15H
				ATTACH;VALUE=URI:Chord
				ACTION:AUDIO
				END:VALARM
				]]>
			</B:default-alarm-vevent-date>
		</A:prop>
	</A:set>
</A:propertyupdate>

Changing the default calendar does not result in any CalDAV requests.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general

@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from 229fb7a to 0fb2955 Compare March 13, 2020 10:58
@georgehrke georgehrke requested review from julien-nc and juliushaertl and removed request for julien-nc March 17, 2020 14:33
@rullzer rullzer mentioned this pull request Apr 4, 2020
80 tasks
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from 0fb2955 to e91636d Compare April 5, 2020 18:59
@rullzer rullzer mentioned this pull request Apr 9, 2020
59 tasks
@skjnldsv
Copy link
Member

Conflicts

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 11, 2020
And add tests to handle schedule-default-calendar-URL

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
itself is deleted

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from e91636d to 0408c37 Compare April 13, 2020 13:07
@tcitworld
Copy link
Member Author

Rebased and php-cs-fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants