Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip session validation during app load (Fixes #20756) #20757

Closed
wants to merge 3 commits into from

Commits on Apr 30, 2020

  1. Skip session validation during app load (Fixes nextcloud#20756)

    Adds parameter to User\Session:getUser() to skip validation, and
    modifies OC_App::getEnabledApps() to use this parameter to skip
    session validation when loading apps.
    
    Signed-off-by: Scott Shambarger <devel@shambarger.net>
    sshambar committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    581d300 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Revert 581d300

    sshambar committed May 4, 2020
    Configuration menu
    Copy the full SHA
    1885d41 View commit details
    Browse the repository at this point in the history
  2. Modify loadApps to always load all protected apps (Fixes nextcloud#20756

    )
    
    Adds a new AppManager method which identifies when all app types
    are protected, loads all apps (without checking user filters).
    
    This has the intended benefit of avoiding calls to
    User\Session:getUser() for these app types, and likely
    invalidating the session before user backends are loaded.
    
    Signed-off-by: Scott Shambarger <devel@shambarger.net>
    sshambar committed May 4, 2020
    Configuration menu
    Copy the full SHA
    ff8695f View commit details
    Browse the repository at this point in the history