Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random_bytes #20915

Merged
merged 1 commit into from
May 11, 2020
Merged

Use random_bytes #20915

merged 1 commit into from
May 11, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented May 11, 2020

Since we don't care if it is human readbale.
The code is backwards compatible with the old format.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Since we don't care if it is human readbale.
The code is backwards compatible with the old format.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the enh/use_random_bytes_in_crypto branch from 421f78d to 35ff4aa Compare May 11, 2020 10:47
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks good.

@nickvergessen
Copy link
Member

Backport till 17?

@rullzer
Copy link
Member Author

rullzer commented May 11, 2020

Backport till 17?

sounds good!

@rullzer
Copy link
Member Author

rullzer commented May 11, 2020

/backport to stable19

@rullzer
Copy link
Member Author

rullzer commented May 11, 2020

/backport to stable18

@rullzer
Copy link
Member Author

rullzer commented May 11, 2020

/backport to stable17

@rullzer rullzer merged commit 7211d44 into master May 11, 2020
@rullzer rullzer deleted the enh/use_random_bytes_in_crypto branch May 11, 2020 12:21
@lynn-stephenson
Copy link
Contributor

Glad to see this issue was fixed! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants