Declare OCA.Search directly, not via a monkey patch #22511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps could use OCA.Search very early on a page load without a problem prior to Nextcloud 20 (current master). Since the unified search work moved some code around, it now was added later, resulting in `TypeError: OCA.Search is not a constructor` errors if the apps did not wrap their calls in a `DOMLoaded` event handler. To ensure existing code continues to work without modification, this patch moves the declaration of the `OCA.Search` API to where we defined `OCA`, instead of monkey-patching it later on. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
3. to review
skjnldsv
approved these changes
Aug 31, 2020
marcelklehr
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps could use OCA.Search very early on a page load without a problem
prior to Nextcloud 20 (current master). Since the unified search work
moved some code around, it now was added later, resulting in
TypeError: OCA.Search is not a constructorerrors if the apps did not wrap theircalls in a
DOMLoadedevent handler.To ensure existing code continues to work without modification, this
patch moves the declaration of the
OCA.SearchAPI to where we definedOCA, instead of monkey-patching it later on.