Fix app password updating out of bounds #22524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
nickvergessen,
MorrisJobke,
ChristophWurst and
juliushaertl
kesselb
reviewed
Aug 31, 2020
| @@ -0,0 +1,53 @@ | |||
| <?php | |||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Suggested change
| declare(strict_types=1); | |
| declare(strict_types=1); |
|
|
||
| $this->manager->updatePasswords($event->getUser()->getUID(), $event->getPassword()); | ||
| } | ||
|
|
ChristophWurst
approved these changes
Sep 3, 2020
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32588: failuremariadb10.4-php7.3Show full logmysql5.6-php7.2Could not fetch logs |
When your password changes out of bounds your Nextcloud tokens will become invalid. There is no real way around that. However we should make sure that if you successfully log in again your passwords are all updates * Added event listener to the PostLoggedInEvent so that we can act on it - Only if it is not a token login * Make sure that we actually reset the invalid state when we update a token. Else it keeps being marked invalid and thus not used. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/apppassword_update
branch
from
b316fdf
to
0452877
Compare
rullzer
added
4. to release
|
/backport to stable19 |
|
/backport to stable18 |
This was referenced Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When your password changes out of bounds your Nextcloud tokens will
become invalid. There is no real way around that. However we should make
sure that if you successfully log in again your passwords are all
updates
token. Else it keeps being marked invalid and thus not used.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl