-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dashboard statuses toggling #22531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehrke
reviewed
Sep 1, 2020
juliushaertl
reviewed
Sep 1, 2020
julien-nc
force-pushed
the
fix/save-statuses
branch
from
September 1, 2020 14:11
0cb0452
to
0f7aeb2
Compare
@juliushaertl Right. Just to be clear, I think $statuses = ($statuses && count($statuses) > 0) ? $statuses : ['weather' => true]; is necessary to make sure the case of having '{}' stored in preferences is handled safely. |
juliushaertl
reviewed
Sep 1, 2020
julien-nc
force-pushed
the
fix/save-statuses
branch
from
September 1, 2020 14:39
0f7aeb2
to
c23949d
Compare
juliushaertl
approved these changes
Sep 2, 2020
…t in UI Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/save-statuses
branch
from
September 4, 2020 16:20
c23949d
to
e8f37dd
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32662: failureacceptance-app-files
Show full log
|
skjnldsv
approved these changes
Sep 4, 2020
/compile amend / |
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix empty php array becoming an array instead of an object when passed to UI. This was preventing statuses state saving if default value was loaded.
refs #22468