Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend integration tests for "files:transfer-ownership" command #22761

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Extend integration tests for "files:transfer-ownership" command #22761

merged 3 commits into from
Sep 14, 2020

Commits on Sep 10, 2020

  1. Check whether file exists or not after transferring ownership 

    The integration tests did not verify that the files were actually
transferred between the users, only that the files were downloadable.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    d3d01d6 View commit details
    Browse the repository at this point in the history

  2. Check share ownership after transferring file ownership 

    The integration tests did not verify that the shares were actually
transferred between the users (or that they were removed due to being
transferred to the sharee).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0ce8096 View commit details
    Browse the repository at this point in the history

  3. Add integration tests for transferring ownership of reshares 

    Currently only transferring ownership of a reshare with a group to a
user in the group is possible.

When transferring ownership of a reshare with another user or with a
group to a user not in the group restoring the share fails (but the
command succeeds, it only fails for the specific files that are
reshares).

When transferring ownership of a path that is a reshare the command
fails (as when a specific path is provided the path tries to move the
file, it does not take into account reshares).

The added integration tests reflect the above behaviours.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    58d57b3 View commit details
    Browse the repository at this point in the history