-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to get the unread count for multiple objects in one go #23792
Add a function to get the unread count for multiple objects in one go #23792
Conversation
Don't get back the expected results... |
Just fixed that in the commit before |
0bf1131
to
0d8d2c9
Compare
I tested that |
All working now. |
With this and master I get the exact same 2 times 10 requests (10 against oc_comments and 10 against oc_comments_read_markers) 😢 I basically shared 10 files and left a comment on each of them. Then did a PROPFIND. |
Just checked again and it works 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
Signed-off-by: Joas Schilling <coding@schilljs.com>
6a94fae
to
533a14d
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
533a14d
to
8bd39fc
Compare
I don't know why Psalm triggers this only in that PR here:
But other code in the same file also use it and thus I would see it as unrelated and needs to be fixed in a separate PR. |
Signed-off-by: Joas Schilling coding@schilljs.com