Remove useless ini_set calls

[solracsf]

They're all PHP_INI_SYSTEM.
See comments below 👍

[kesselb]

Did you run into an issue because the value is wrong?

• The default for max_file_uploads is 20 and that seems enough. It's not relevant anyway because max_file_uploads limits the number of uploaded files per request. Each file is uploaded in a own request usually.
• Afaik a positive integer is considered as true. I think we should remove the ini_set call for file_uploads. That's something for htaccess or user.ini.

[solracsf]

I was simply checking what ini_set calls Nextcloud was making in a ini_set disabled host to set those values manually.

It should be either fixed with this PR or (re)moved as you've said.

[kesselb]

	file_uploads	max_file_uploads
Master	On	20
This PR	On	50

I don't see why we need to increase max_file_uploads.

[solracsf]

As far as i understand, this can't even be changed trough .htaccess our ini_set...
https://bugs.php.net/bug.php?id=50684

So the best option is to remove it.

[kesselb]

As far as i understand, this can't even be changed trough .htaccess our ini_set...

That's correct. file_uploads is also PHP_INI_SYSTEM and not changeable via ini_set. Please remove it.

[kesselb]

And if your are on it please remove upload_max_filesize and post_max_size because they are PHP_INI_SYSTEM too ;)

3 method calls less 🤣 🥳

[kesselb]

I found another one 🙈

max_input_time is PHP_INI_PERDIR (https://www.php.net/manual/en/info.configuration.php)

Would be nice to squash all commits together (or drop the old ones) and sign off (https://github.com/nextcloud/server/pull/24934/checks?check_run_id=1637306644 for some hints)

Thanks for cleaning this up 👍

[rullzer]

Could you squash this to 1 commit?
Then lets get it in.