Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreliable ViewTest #24961

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Fix unreliable ViewTest #24961

merged 2 commits into from
Jan 5, 2021

Conversation

juliushaertl
Copy link
Member 

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

In addition to properly mocking writeStream and throwing an exception the tests failed because the result in moveFromStorage was constructed using an assignment operator which lead to (int)1 instead of a boolean.

@juliushaertl
Fix writeStream mocking
ee842f1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Properly handle result when copying with failure and throw in tests
98560c8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug 3. to review Waiting for reviews labels Jan 5, 2021
@rullzer
Copy link
Member

rullzer commented Jan 5, 2021

/backport to stable20

@rullzer rullzer added this to the Nextcloud 21 milestone Jan 5, 2021
@juliushaertl juliushaertl merged commit 9b9c1aa into master Jan 5, 2021
@juliushaertl juliushaertl deleted the bugfix/noid/copy-tests branch January 5, 2021 14:49
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 5, 2021
Merged
@rullzer rullzer mentioned this pull request Jan 6, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@blizzz blizzz Awaiting requested review from blizzz

@kesselb kesselb Awaiting requested review from kesselb

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@juliushaertl @rullzer @icewind1991