Fix clearing the label of a share #25017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
requested review from
rullzer,
MorrisJobke,
ChristophWurst and
skjnldsv
|
/backport to stable20 |
rullzer
approved these changes
Jan 7, 2021
|
Needs a rebase |
ChristophWurst
approved these changes
Jan 8, 2021
rullzer
force-pushed
the
fix-clearing-the-label-of-a-share
branch
from
8328336
to
8df7765
Compare
|
/compile amend / |
When the label is being edited its value is stored in "newLabel", and the original label is shown only if "newLabel" is not set. However, as it was checked against any falsy value instead of only undefined when the label was cleared and thus it has an empty value the original label was shown instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix-clearing-the-label-of-a-share
branch
from
8df7765
to
fb19d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #21357
When the label is being edited its value is stored in
newLabel, and the original label is shown only ifnewLabelis not set. However, as it was checked against any falsy value instead of only undefined when the label was cleared and thus it has an empty value the original label was shown instead.How to test
Result with this pull request
The label is cleared.
Result without this pull request
After pressing the last backspace the original label appears again.
*Note that if the whole label is selected and backspace or delete are pressed then the label is cleared as expected.