Fix popover width #2545
Merged
Fix popover width #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @LukasReschke and @rullzer to be potential reviewers. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix-popover-width
branch
from
841c759
to
2eca4e6
Compare
|
@skjnldsv Looks good now, only the offset on the personal settings looks a bit off. margin:0; on .federationScopeMenu should fix that. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
|
👍 Thanks for the fast fixing @skjnldsv @nextcloud/designers for another reviewer |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2544
For référence: the popover menu should be inside the div containing the dots icon.
The required right distance to the border (or padding, whatever you want to use) of the three-dot icon should be 14px (5 for menu margin and 6 for arrow position)
Is there a place in the dev docs where I can put that?
@juliushaertl