Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a php8 warning #27277

Closed
wants to merge 1 commit into from
Closed

Fix a php8 warning #27277

wants to merge 1 commit into from

Conversation

jvoisin
Copy link

@jvoisin jvoisin commented May 29, 2021

The usort's callback must return values in {-1, 0, 1} and not
a boolean, since this behaviour is deprecated.

This should also fix the following warning:
"Error: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero at /var/www/nextcloud/lib/public/AppFramework/Http/Template/PublicTemplateResponse.php#101"

This partially addresses #25806

The usort's callback must return values in {-1, 0, 1} and not
a boolean, since this behaviour is deprecated.

This should also fix the following warning:
"Error: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero at /var/www/nextcloud/lib/public/AppFramework/Http/Template/PublicTemplateResponse.php#101"

This partially addresses #25806

Signed-off-by: jvoisin <julien.voisin@dustri.org>
@jvoisin
Copy link
Author

jvoisin commented May 29, 2021

Duplicate of #26494, my bad.

@jvoisin jvoisin closed this May 29, 2021
@jvoisin jvoisin deleted the fix_usort branch May 29, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant