Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Fix some php 8 warnings #27415

Merged
merged 3 commits into from
Jun 14, 2021
Merged

[stable21] Fix some php 8 warnings #27415

merged 3 commits into from
Jun 14, 2021

Commits on Jun 7, 2021

  1. Fix functions taking optional parameters before required ones 

    PHP 8 shows deprecation warnings about this, see #25806
Removes the "default" values, as they actually are required parameters anyway.

Signed-off-by: Richard de Boer <git@tubul.net>
    @rigrig @backportbot
    rigrig authored and backportbot[bot] committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    7e9d459 View commit details
    Browse the repository at this point in the history

  2. Fix a usort comparison function returning a boolean instead of an int… 

    …eger

PHP 8 shows deprecation warnings about this, see #25806

Signed-off-by: Richard de Boer <git@tubul.net>
    @rigrig @backportbot
    rigrig authored and backportbot[bot] committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    088118f View commit details
    Browse the repository at this point in the history

  3. Check whether output buffering is active before turning it off 

    Before we just turned it off and @Suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <git@tubul.net>
    @rigrig @backportbot
    rigrig authored and backportbot[bot] committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    9f3824b View commit details
    Browse the repository at this point in the history