Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocompletion for password reset #27949

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Add autocompletion for password reset #27949

merged 1 commit into from
Oct 25, 2021

Conversation

CarlSchwan
Copy link
Member

Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Close #27885

Signed-off-by: Carl Schwan carl@carlschwan.eu

@szaimen szaimen added the 3. to review Waiting for reviews label Jul 13, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 13, 2021
@julien-nc
Copy link
Member

@szaimen Are you sure you want to assign this PR? Maybe you wanted to request reviews? 😁

@szaimen
Copy link
Contributor

szaimen commented Jul 13, 2021

Are you sure you want to assign this PR? Maybe you wanted to request reviews? 😁

You are right. I misclicked 😅

@CarlSchwan CarlSchwan mentioned this pull request Jul 13, 2021
Closed
julien-nc
julien-nc reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This could also be done in login page and password reset page.
core/src/components/login/LoginForm.vue
core/src/components/login/UpdatePassword.vue

@CarlSchwan CarlSchwan force-pushed the work/carl/password-reset-autocomplete branch from 281a8fa to 66e1f88 Compare July 13, 2021 16:09
@CarlSchwan
Copy link
Member Author

Nice! This could also be done in login page and password reset page.
core/src/components/login/LoginForm.vue
core/src/components/login/UpdatePassword.vue

Good idea :) Just did that and also unified the autocapitalize="none" autocorrect="off" behavior with the two places you linked. Not sure it's really needed since I expect browsers to be clever enough to not autocorrect password fields by default but at least it's consistent :)

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 13, 2021
@CarlSchwan CarlSchwan force-pushed the work/carl/password-reset-autocomplete branch from 66e1f88 to 7344b2a Compare July 13, 2021 16:16
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 13, 2021
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the work/carl/password-reset-autocomplete branch from 7344b2a to 1dd402b Compare July 13, 2021 16:34
@szaimen

This comment has been minimized.

Sign in to view
@szaimen

This comment has been minimized.

Sign in to view
@CarlSchwan CarlSchwan force-pushed the work/carl/password-reset-autocomplete branch from 923e45a to bf2304a Compare July 14, 2021 09:33
@julien-nc julien-nc self-requested a review July 14, 2021 09:53
@julien-nc julien-nc requested a review from Pytal July 14, 2021 10:23
@szaimen szaimen force-pushed the work/carl/password-reset-autocomplete branch from cb6130b to 55e149d Compare July 14, 2021 22:15
@szaimen
Copy link
Contributor

szaimen commented Jul 14, 2021

Solved the conflicting files. But I fear there is still the need to compile and push the js.
/compile amend / unfortunatlely didn't work the last times...

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the work/carl/password-reset-autocomplete branch from 55e149d to ab1f4a6 Compare July 14, 2021 22:35
@szaimen szaimen force-pushed the work/carl/password-reset-autocomplete branch from ab1f4a6 to 4e3b538 Compare July 14, 2021 22:39
@artonge
Copy link
Contributor

artonge commented Jul 15, 2021

I compiled the files, but can't push on @CarlSchwan's branch :(

@CarlSchwan
Copy link
Member Author

I will compile the files and push them after lunch

@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

/rebase

@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

Unfortunately the fork seems to be still unpushable...

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 31, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv
Copy link
Member

@CarlSchwan rebase?

@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021
@CarlSchwan @Pytal
Add autocompletion for password reset
b7a35af 
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.

Close nextcloud#27885

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-Authored-By: Julien Veyssier <eneiluj@posteo.net>
Co-Authored-By: Pytal <24800714+Pytal@users.noreply.github.com>
@CarlSchwan CarlSchwan force-pushed the work/carl/password-reset-autocomplete branch from 4e3b538 to b7a35af Compare October 22, 2021 10:18
@artonge artonge merged commit 317d973 into nextcloud:master Oct 25, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 24, Nextcloud 23 Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

Changing the password does not work properly on macOS/Safari
6 participants
@CarlSchwan @julien-nc @szaimen @artonge @skjnldsv @Pytal