[stable21] Fix svg icons disapearing in app navigation when text overflows #27956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
The issue is caused by the icon being positionned with negative margins and the `overflow: hidden` rule when hide the icon when the text overflows. Remove positioning with negative margins. This was only happening in Firefox. This fix #23849 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud
bot
requested review from
artonge,
CarlSchwan,
julien-nc,
jancborchardt,
nimishavijay and
szaimen
szaimen
approved these changes
Jul 13, 2021
MichaIng
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #27936