Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Folder->getById() when a single storage is mounted multiple times #28220

Merged
merged 1 commit into from
Aug 9, 2021
Merged

fix Folder->getById() when a single storage is mounted multiple times #28220

merged 1 commit into from
Aug 9, 2021

Conversation

icewind1991
Copy link
Member

it's a bit of a hacky solution but doesn't require any migration at least

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 28, 2021
@icewind1991 icewind1991 added this to the Nextcloud 23 milestone Jul 28, 2021
@icewind1991
fix Folder->getById() when a single storage is mounted multiple times
5c2e7c7 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the get-by-id-multiple-mounts-single-storage branch from f8bc970 to 5c2e7c7 Compare July 28, 2021 15:21
juliushaertl
juliushaertl approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliushaertl juliushaertl requested a review from a team August 9, 2021 15:31
@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2021

/backport to stable22

@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2021

/backport to stable21

@skjnldsv
Copy link
Member

skjnldsv commented Aug 9, 2021

/backport to stable20

@skjnldsv skjnldsv merged commit 67e6468 into master Aug 9, 2021
@skjnldsv skjnldsv deleted the get-by-id-multiple-mounts-single-storage branch August 9, 2021 17:27
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 9, 2021
This was referenced Aug 9, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @skjnldsv @juliushaertl