properly handle cases where cache wrappers block access #28385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Aug 11, 2021
artonge
approved these changes
Aug 24, 2021
|
possibly related, or needs additional fixing. nextcloud/groupfolders#1464 |
|
@icewind1991 seems psalm not happy |
Merged
|
/rebase |
nextcloud-command
force-pushed
the
search-handle-wrapper-filtered-entries
branch
from
bc88ef3
to
99dbe6a
Compare
This comment has been minimized.
This comment has been minimized.
skjnldsv
force-pushed
the
search-handle-wrapper-filtered-entries
branch
from
99dbe6a
to
9f3a2ab
Compare
skjnldsv
added
4. to release
`CacheWrapper::formatCacheEntry` can return false for files that should be filtered out Signed-off-by: Robin Appelman <robin@icewind.nl>
skjnldsv
force-pushed
the
search-handle-wrapper-filtered-entries
branch
from
9f3a2ab
to
118c647
Compare
|
Fixed psalm, ready to merge |
|
backport? EDIT: groupfolders seems to also behave in stablexx branches following server. Backporting up to reported version, 22 |
|
/backport to stable22 |
|
Is it possible and should be backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheWrapper::formatCacheEntrycan return false for files that should be filtered outFixes nextcloud/groupfolders#1621