Fix translated app details #29004
Merged
Fix translated app details #29004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
3. to review
nickvergessen
commented
Sep 30, 2021
| @@ -163,8 +162,7 @@ public function installApp(string $appId, bool $forceEnable = false): string { | |||
| //run appinfo/install.php | |||
| self::includeAppScript($basedir . '/appinfo/install.php'); | |||
|
|
|||
| $appData = OC_App::getAppInfo($appId); | |||
There was a problem hiding this comment.
This is 6y old, the getAppInfo in line 117 is 5y old. I don't see much sense in it. Either they read the same info.xml anyway or we read data from 2 different sources and then either we run old repair-steps and save new remote/public handlers afterwards or the other way around.
|
Related to #6024 ? |
|
Yes, should fix it |
blizzz
approved these changes
Sep 30, 2021
nickvergessen
requested review from
tcitworld,
a team,
PVince81 and
icewind1991
and removed request for
a team
Merged
skjnldsv
approved these changes
Oct 13, 2021
skjnldsv
added
4. to release
|
/backport to stable22 |
|
/backport to stable21 |
This was referenced Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6024