Fix status menu item not listening to status change events #29313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile amend / |
skjnldsv
approved these changes
Oct 19, 2021
nextcloud-command
force-pushed
the
fix/status-menu-update
branch
from
2ede745
to
25c263d
Compare
Pytal
approved these changes
Oct 20, 2021
skjnldsv
added
4. to release
This makes it so that the status menu item listens to user_status:status.updated events even when they are triggered outside of the user status modal. Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
force-pushed
the
fix/status-menu-update
branch
from
25c263d
to
89112e5
Compare
|
file-sharing acceptance tests are failing :/ Very probably unrelated |
|
Fixes it, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the status menu item listens to user_status:status.updated
events even when they are triggered outside of the user status modal.
Signed-off-by: Carl Schwan carl@carlschwan.eu