Populate missing profile config defaults #29330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
bug
3. to review
Pytal
requested review from
nickvergessen,
ArtificialOwl and
skjnldsv
and removed request for
a team
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/missing-profile-config-defaults
branch
from
e019f64
to
bff02f5
Compare
skjnldsv
approved these changes
Oct 20, 2021
|
Fixes it! 👍 |
blizzz
reviewed
Oct 20, 2021
blizzz
reviewed
Oct 20, 2021
| $config = $this->configMapper->get($targetUser->getUID()); | ||
| // Merge defaults with the existing config in case the defaults are missing | ||
| $config->setConfigArray(array_merge($defaultProfileConfig, $config->getConfigArray())); | ||
| $this->configMapper->update($config); |
There was a problem hiding this comment.
this does not cause superflouus writes to the DB, does it? When nothing has changed.
There was a problem hiding this comment.
No superfluous writes as it is handled here
server/lib/public/AppFramework/Db/QBMapper.php
Lines 185 to 189 in 49e727f
blizzz
approved these changes
Oct 20, 2021
Pytal
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge defaults with the existing profile config queried from the database to ensure that all expected properties are set.