Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fair use push #29363

Merged
merged 4 commits into from
Oct 23, 2021
Merged

Fair use push #29363

merged 4 commits into from
Oct 23, 2021

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Oct 21, 2021
@tcitworld tcitworld mentioned this pull request Oct 22, 2021
Open
@nickvergessen nickvergessen force-pushed the fair-use-push branch 2 times, most recently from af8feb7 to a90f100 Compare October 22, 2021 08:58
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 22, 2021
@nickvergessen nickvergessen marked this pull request as ready for review October 22, 2021 09:02
@nickvergessen nickvergessen requested review from vitormattos, skjnldsv, a team, ArtificialOwl and icewind1991 and removed request for a team October 22, 2021 09:02
skjnldsv
skjnldsv requested changes Oct 22, 2021
View reviewed changes
core/js/setupchecks.js Outdated Show resolved Hide resolved
blizzz
blizzz approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but a remark.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2021
nickvergessen and others added 4 commits October 23, 2021 00:54
@nickvergessen
Fair use of push notifications
b578a1e 
We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@vitormattos @nickvergessen
add check isFairUseOfFreePushService on login
d613b32 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos @nickvergessen
Show warning on admin settings page
e55ceb2 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos @nickvergessen
show warning on personal settings page
6f7ca34 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@skjnldsv skjnldsv merged commit a06001e into master Oct 23, 2021
@skjnldsv skjnldsv deleted the fair-use-push branch October 23, 2021 08:53
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
@solracsf solracsf mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@nickvergessen nickvergessen

@vitormattos vitormattos

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: activity and notification
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @vitormattos @blizzz @kesselb @skjnldsv