Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix "never catch" catches in OC_App" #29425

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

nickvergessen
Copy link
Member

Reverts #28138 to get rid of the warning spam:

The use statement with non-compound name 'Throwable' has no effect

OC_App file has no namespace so importing a non-namespaced thing yields the warning.

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Oct 25, 2021
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Oct 25, 2021
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv merged commit d231d26 into master Oct 25, 2021
@skjnldsv skjnldsv deleted the revert-28138-zorn-v-patch-2 branch October 25, 2021 07:25
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants