Calendar events email reminders #3044

tcitworld · 2017-01-12T13:35:37Z

fixes #3979

Okay, this seems ready.

What it looks like:

Email

Notifications

(Browser notifications come as well)

Edited by @georgehrke:

ToDo:

support recurring events
support repeat / duration

mention-bot · 2017-01-12T13:35:38Z

@tcitworld, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @rullzer and @icewind1991 to be potential reviewers.

apps/dav/lib/CalDAV/CalDavBackend.php

nickvergessen

What I dislike about this is all the duplication of notifications we will get with that.
The plan is to have notifications integrated into the mobile and desktop clients as well. So when you have an event coming up, you will have 4 notifications (laptop nextcloud, laptop calendar, phone nextcloud, phone calendar).

That is why I always stayed away from this notifications. Might make sense to have them in the web ui, but I think most people have at least one client running which already gives the notifications....

apps/dav/appinfo/app.php

georgehrke · 2017-02-26T15:55:35Z

That is why I always stayed away from this notifications. Might make sense to have them in the web ui, but I think most people have at least one client running which already gives the notifications....

@nickvergessen
The calendar standard defines different kinds of alarms. Audio, display and email..
E-Mail alarms should obviously only be triggered when the user actually asked for an email :)

rullzer · 2017-04-03T19:18:51Z

What is the status here? Can this be reviewed soon?

georgehrke · 2017-06-02T08:45:14Z

@tcitworld What's your schedule for this feature? :)

tcitworld · 2017-06-30T13:05:25Z

Will change this to work on the backend already used for Activities made by @nickvergessen

tcitworld · 2017-07-13T09:18:07Z

Should emails reminders be sent to all ATTENDEES or just nextcloud users ?
cc @georgehrke @jancborchardt @nickvergessen

codecov · 2017-07-13T13:43:05Z

Codecov Report

Merging #3044 into master will decrease coverage by 22.75%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #3044       +/-   ##
=============================================
- Coverage     53.77%   31.01%   -22.76%     
+ Complexity    22746    22368      -378     
=============================================
  Files          1405     1383       -22     
  Lines         86898    85091     -1807     
  Branches       1328     1329        +1     
=============================================
- Hits          46727    26394    -20333     
- Misses        40171    58697    +18526

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/CalDAV/Reminder/Notifier.php	`0% <0%> (ø)`	`4 <4> (?)`
apps/dav/lib/RootCollection.php	`0% <0%> (-95.66%)`	`1 <0> (ø)`
apps/dav/lib/CalDAV/CalDavBackend.php	`0% <0%> (-86.04%)`	`223 <9> (+5)`
apps/dav/lib/CalDAV/Reminder/ReminderJob.php	`0% <0%> (ø)`	`8 <8> (?)`
apps/dav/lib/AppInfo/Application.php	`0% <0%> (-46.16%)`	`14 <2> (+1)`
apps/dav/lib/CalDAV/Reminder/ReminderService.php	`0% <0%> (ø)`	`6 <6> (?)`
apps/dav/appinfo/app.php	`0% <0%> (-26.32%)`	`0 <0> (ø)`
apps/user_ldap/lib/Migration/UUIDFixUser.php	`0% <0%> (-100%)`	`1% <0%> (ø)`
...ib/private/Files/Config/UserMountCacheListener.php	`0% <0%> (-100%)`	`2% <0%> (ø)`
apps/comments/lib/AppInfo/Application.php	`0% <0%> (-100%)`	`1% <0%> (ø)`
... and 503 more

Changes

georgehrke · 2017-07-13T15:00:57Z

Should emails reminders be sent to all ATTENDEES or just nextcloud users ?

Did you check any RFC for an answer on that? :)

tcitworld · 2017-07-17T08:26:05Z

  When the action is "EMAIL", the alarm MUST include a "DESCRIPTION"
  property, which contains the text to be used as the message body,
  a "SUMMARY" property, which contains the text to be used as the
  message subject, and one or more "ATTENDEE" properties, which
  contain the email address of attendees to receive the message.  It
  can also include one or more "ATTACH" properties, which are
  intended to be sent as message attachments.  When the alarm is
  triggered, the email message is sent.

  [...]

  In an EMAIL alarm, the intended alarm effect is for an email
  message to be composed and delivered to all the addresses
  specified by the "ATTENDEE" properties in the "VALARM" calendar
  component.  The "DESCRIPTION" property of the "VALARM" calendar
  component MUST be used as the body text of the message, and the
  "SUMMARY" property MUST be used as the subject text.  Any "ATTACH"
  properties in the "VALARM" calendar component SHOULD be sent as
  attachments to the message.

@georgehrke @jancborchardt Today, when you set an alarm, you are not automatically added as an attendee, but I guess you would like to get the notifications anyway.
What about people with whom the calendar is shared (a group, for instance) ? Should they automatically get the notifications too while not manually added to ATTENDEES (they can be a lot) ?

Maybe an issue in calendar repo to automatically add yourself as an attendee ? Or another one to add a group as attendee ?

tcitworld · 2017-07-17T08:27:08Z

Also, if someone plz have a look why my notifications aren't displayed. :'(

jancborchardt · 2017-07-17T10:04:36Z

Sharing an event with someone should mean they are invited to add themselves as attending. But not set them as attending automatically.

tcitworld · 2017-07-17T11:42:15Z

add themselves as attending

Would like to discuss more on that on the calendar app repo, maybe a easier way to add yourself as an attendee instead of typing your own username? A checkbox?
Would also be great if someone could tell me how Apple's iCal handles this issue for instance.

pixelipo · 2017-10-13T10:17:44Z

Hi @tcitworld any status on this? It's a killer feature for me and if there's a bounty, I'm willing to pitch in.

Also if you need some dev/design help, let me know.

tcitworld · 2017-10-13T10:22:05Z

No bounty yet. Feel free to have a look and add answers to my questions.

georgehrke · 2017-11-11T16:29:52Z

Not sure if there is a little confusion here:

We are talking about different kinds of attendees here.
There can be attendees in VEvents, the one you see in the event editor, and attendees inside VAlarm blocks. The latter one are for sending out e-mail notifications. You can be an attendee inside the VAlarm block without being an actual attendee of the event.

What about people with whom the calendar is shared (a group, for instance) ?

See my comment in #679 (comment)

Should they automatically get the notifications too while not manually added to ATTENDEES (they can be a lot) ?

They should be able to manage their own VAlarm block for each event and hence be able to add themselves for reminders. Not sure about the default here.
If u are an actual attendee of the event, you should get a notification too.

Maybe an issue in calendar repo to automatically add yourself as an attendee ?

Yep, please open one :)

Or another one to add a group as attendee ?

Maybe. It's important to provide an opt-out mechanism here imho.

MorrisJobke · 2017-11-14T13:39:21Z

@nickvergessen @tcitworld @georgehrke It doesn't look like something for 13, right?

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php

fancycode · 2019-08-13T09:28:51Z

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php

+				$message->setTo([$emailAddress]);
+				$message->useTemplate($template);
+
+				try {


While you're at it: it would be great if you could dispatch an event here containing the message. This can be subscribed by other apps so they can modify / extend the message before it is sent out.

Can we do that in a separate PR please? We are planning to release a beta of 17 later this week, so this has to get in if we want it in 17.

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php

rullzer

In general I'm all for merging this. I'm sure there are things we didn't think of yet. But lets get this in before it gets to huge.

I just wonder about the migration change.

apps/dav/lib/BackgroundJob/BuildReminderIndexBackgroundJob.php

rullzer · 2019-08-13T18:11:25Z

apps/dav/lib/CalDAV/Reminder/Backend.php

+ *
+ * @package OCA\DAV\CalDAV\Reminder
+ */
+class Backend {


I'm fine with this for now. But it might make sense to try to eventually convert this to the Entity stuff of the appframework.

rullzer · 2019-08-13T18:16:38Z

apps/dav/lib/CalDAV/Reminder/Notifier.php

+		if ($diff->invert) {
+			$title = $this->l10n->t('%s (in %s)', [$title, $diffLabel]);
+		} else {
+			$title = $this->l10n->t('%s (%s ago)', [$title, $diffLabel]);


So i guess we either have to give good hints to the translators. Or we have to somehow fix this later to have proper translations. Because I can already see languages where this looks weird.

rullzer · 2019-08-13T18:18:18Z

apps/dav/lib/CalDAV/Reminder/ReminderService.php

+	/** @var ITimeFactory */
+	private $timeFactory;
+
+	public const REMINDER_TYPE_EMAIL = 'EMAIL';


If we have the types here. Shouldn't we just reference them from the providers themselfs?

as in have a method getSupportedTypes?

if you configure email reminder alert to calendar on nextcloud already please send step to configure take me

rullzer · 2019-08-13T18:18:44Z

apps/dav/lib/CalDAV/Reminder/ReminderService.php

+		}
+
+		switch($action) {
+			case '\OCA\DAV\CalDAV\CalDavBackend::createCalendarObject':


Ah magic string ;)
But yeah lets do it for now.

apps/dav/lib/Migration/Version1004Date20170825134824.php

rullzer · 2019-08-15T13:45:15Z

Depends on nextcloud/3rdparty#321

rullzer

Looks good.
Lets see if phan is happy and get it in.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

…ckground-job Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

…xtcloud 17 Signed-off-by: Georg Ehrke <developer@georgehrke.com>

…nstead Signed-off-by: Georg Ehrke <developer@georgehrke.com>

…er, better then not showing reminders at all for now Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Mic92 · 2019-12-04T15:57:06Z

Is this part of 17.0.1?

EDIT: It is. However I don't get notifications also sending emails works. I suppose those are triggered by cronjobs?

tcitworld added 2. developing Work in progress feature: dav labels Jan 12, 2017

nickvergessen reviewed Jan 12, 2017

View reviewed changes

apps/dav/lib/CalDAV/CalDavBackend.php Outdated Show resolved Hide resolved

nickvergessen reviewed Jan 12, 2017

View reviewed changes

apps/dav/lib/CalDAV/CalDavBackend.php Outdated Show resolved Hide resolved

nickvergessen reviewed Jan 12, 2017

View reviewed changes

apps/dav/lib/CalDAV/CalDavBackend.php Outdated Show resolved Hide resolved

nickvergessen previously requested changes Jan 12, 2017

View reviewed changes

apps/dav/appinfo/app.php Outdated Show resolved Hide resolved

apps/dav/appinfo/app.php Outdated Show resolved Hide resolved

georgehrke mentioned this pull request Mar 21, 2017

Implement calendar notifications by email (sent from the server) #3979

Closed

rullzer added this to the Nextcloud 13 milestone May 23, 2017

tcitworld force-pushed the dav-email-reminders branch from 11049d2 to e8c0e67 Compare June 21, 2017 14:13

tcitworld force-pushed the dav-email-reminders branch from e8c0e67 to 5554ec6 Compare July 13, 2017 13:42

leonklingele mentioned this pull request Aug 16, 2017

Spreed integration nextcloud/calendar#563

Closed

10 tasks

MorrisJobke modified the milestones: Nextcloud 13, Nextcloud 14 Nov 14, 2017

hockdudu suggested changes Aug 12, 2019

View reviewed changes

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php Outdated Show resolved Hide resolved

fancycode reviewed Aug 13, 2019

View reviewed changes

georgehrke force-pushed the dav-email-reminders branch from 7885830 to de14dff Compare August 13, 2019 10:29

tcitworld commented Aug 13, 2019

View reviewed changes

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php Outdated Show resolved Hide resolved

rullzer requested changes Aug 13, 2019

View reviewed changes

georgehrke modified the milestones: Nextcloud 18, Nextcloud 17 Aug 15, 2019

rullzer approved these changes Aug 15, 2019

View reviewed changes

tcitworld and others added 10 commits August 15, 2019 20:02

Support event reminders (email and notifications)

7bddcc0

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

add occ dav:send-event-reminders, so you don't have to rely on the ba…

d74315a

…ckground-job Signed-off-by: Georg Ehrke <developer@georgehrke.com>

run send reminders background-job only when mode is not set to occ

36b9b51

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

smaller syntax changes to CalDAV reminder classes

11fa451

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Implement getID and getName in Reminder/Notifier as required since Ne…

a6f7926

…xtcloud 17 Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Stop using deprecated registerNotifier, use registerNotifierService i…

c514752

…nstead Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Provide a fake AudioProvider that is basically the same as PushProvid…

7c4a8a3

…er, better then not showing reminders at all for now Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Support recurring events + repeating alarms

bcce568

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Add repair step to register reminder index for existing events

2d6473e

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Final fixes

4d28a45

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

rullzer force-pushed the dav-email-reminders branch from a65c3cf to 4d28a45 Compare August 15, 2019 18:05

rullzer merged commit 6ef7ba2 into master Aug 15, 2019

rullzer deleted the dav-email-reminders branch August 15, 2019 19:21

georgehrke mentioned this pull request Aug 29, 2019

Display event alarms in calendar nextcloud/calendar#51

Closed

This comment has been minimized.

Sign in to view

tcitworld mentioned this pull request Oct 30, 2019

Enh/share expiration notification #17727

Merged

4 tasks

miaulalala mentioned this pull request Oct 21, 2022

Calendar sends duplicate notifications if there is an additional attendee [$250] #21370

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calendar events email reminders #3044

Calendar events email reminders #3044

tcitworld commented Jan 12, 2017 •

edited by georgehrke

Loading

mention-bot commented Jan 12, 2017

nickvergessen left a comment

georgehrke commented Feb 26, 2017

rullzer commented Apr 3, 2017

georgehrke commented Jun 2, 2017

tcitworld commented Jun 30, 2017

tcitworld commented Jul 13, 2017 •

edited

Loading

codecov bot commented Jul 13, 2017

georgehrke commented Jul 13, 2017

tcitworld commented Jul 17, 2017

tcitworld commented Jul 17, 2017

jancborchardt commented Jul 17, 2017

tcitworld commented Jul 17, 2017 •

edited

Loading

pixelipo commented Oct 13, 2017

tcitworld commented Oct 13, 2017

georgehrke commented Nov 11, 2017 •

edited

Loading

MorrisJobke commented Nov 14, 2017

fancycode Aug 13, 2019

georgehrke Aug 13, 2019

fancycode Aug 13, 2019

rullzer left a comment

rullzer Aug 13, 2019

rullzer Aug 13, 2019

rullzer Aug 13, 2019

georgehrke Aug 13, 2019

remmesa Sep 10, 2019

rullzer Aug 13, 2019

rullzer commented Aug 15, 2019

rullzer left a comment

This comment has been minimized.

This comment has been minimized.

Mic92 commented Dec 4, 2019 •

edited

Loading

Calendar events email reminders #3044

Calendar events email reminders #3044

Conversation

tcitworld commented Jan 12, 2017 • edited by georgehrke Loading

Email

Notifications

mention-bot commented Jan 12, 2017

nickvergessen left a comment

Choose a reason for hiding this comment

georgehrke commented Feb 26, 2017

rullzer commented Apr 3, 2017

georgehrke commented Jun 2, 2017

tcitworld commented Jun 30, 2017

tcitworld commented Jul 13, 2017 • edited Loading

codecov bot commented Jul 13, 2017

Codecov Report

georgehrke commented Jul 13, 2017

tcitworld commented Jul 17, 2017

tcitworld commented Jul 17, 2017

jancborchardt commented Jul 17, 2017

tcitworld commented Jul 17, 2017 • edited Loading

pixelipo commented Oct 13, 2017

tcitworld commented Oct 13, 2017

georgehrke commented Nov 11, 2017 • edited Loading

MorrisJobke commented Nov 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rullzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rullzer commented Aug 15, 2019

rullzer left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

Mic92 commented Dec 4, 2019 • edited Loading

tcitworld commented Jan 12, 2017 •

edited by georgehrke

Loading

tcitworld commented Jul 13, 2017 •

edited

Loading

tcitworld commented Jul 17, 2017 •

edited

Loading

georgehrke commented Nov 11, 2017 •

edited

Loading

Mic92 commented Dec 4, 2019 •

edited

Loading