cache mimetype mappings in local cache #30972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saves a db request for every request that touches mimetypes Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
added
2. developing
|
On further thought, this might need some more work to handle new mimetypes properly |
Comment on lines
+169
to
+170
| $this->cache->set('mimetypes', json_encode($this->mimetypes)); | ||
| $this->cache->set('mimeids', json_encode($this->mimetypeIds)); |
There was a problem hiding this comment.
Since it has no TTL, we need to document that people need to clear the cache when they add a new mimetype manually?
E.g. in
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
|
Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saves a db request for every request that touches mimetypes
An alternative would be to cache individual mimetype mappings instead of the full mapping, but I suspect that loading multiple smaller values from cache would be slower than loading one big one