Fixed 'overwritewebroot' not work with 'overwritecondaddr'. #31001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahiro-blab
changed the title
|
|
Merged
Merged
Merged
Merged
Merged
Merged
Merged
solracsf
approved these changes
May 4, 2023
…ddr'. Signed-off-by: Takahiro Nagai <78393959+takahiro-blab@users.noreply.github.com> Signed-off-by: Simon L <szaimen@e.mail.de>
|
rebased and fixed conflicts |
|
CI failure unrelated |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client ip address must be passed to fakeRequest (OC\AppFramework\Http\Request).
Since this is not case, 'overwritewebroot' under 'overwritecondaddr' does not work through OC\AppFramework\HTTP\Request#getScriptName and its isOverwriteCondition.
In order for 'overwritecondaddr' to work properly, PR #30654 must be also merged.