[uc] Prevent PHP request to get killed when using fclose callback (#26775) #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
approved these changes
Jan 19, 2017
| @@ -1146,6 +1146,8 @@ private function basicOperation($operation, $path, $hooks = [], $extraParam = nu | |||
| $unlockLater = false; | |||
| if ($this->lockingEnabled && $operation === 'fopen' && is_resource($result)) { | |||
| $unlockLater = true; | |||
| // make sure our unlocking callback will still be called if connection is aborted | |||
| ignore_user_abort(true); | |||
There was a problem hiding this comment.
Don't think there is a reliable way to do that, since multiple streams can be opened at the same time and there is no clean way to tell when all of them are closed
blizzz
approved these changes
Jan 23, 2017
|
commit signoff missing |
* Prevent PHP request to get killed when using fclose callback * Add ignore_user_abort everywhere where the time limit is set to 0 Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
fcloseafterkill
branch
from
b490188
to
0aaf209
Compare
|
@karlitschek Backport for #1166? |
|
please backport |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From owncloud/core#26775
For #1166