cache storage id mapping in memcache #31905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
PVince81,
juliushaertl and
skjnldsv
and removed request for
a team
icewind1991
added
2. developing
skjnldsv
approved these changes
Apr 8, 2022
CarlSchwan
approved these changes
Apr 8, 2022
juliushaertl
reviewed
Apr 8, 2022
| public function clearCache() { | ||
| $this->cache = []; | ||
| $this->memCache->clear(); |
There was a problem hiding this comment.
Might be something to check where this is being called, clearing redis with a prefix might be a bit slow due to the keys command having a O(n) runtime.
Merged
Merged
Merged
Merged
|
/rebase |
|
Apparently tests need fixing... |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
added
4. to release
|
skjnldsv
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves a query for every storage that is being used