Support theme meta w3c standard #32231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
PVince81,
artonge,
vanpertsch and
szaimen
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Not really, no. Could be done in a follow-up I suppose... |
Ah! But it's also kinda related to the feature, sorry I misunderstood :) |
artonge
approved these changes
May 2, 2022
Merged
Merged
Merged
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
szaimen
requested review from
a team and
Pytal
and removed request for
vanpertsch,
a team and
szaimen
szaimen
added
3. to review
Merged
szaimen
added
2. developing
skjnldsv
force-pushed
the
feat/theming-scheme-meta
branch
3 times, most recently
from
d0cf244
to
4e2b616
Compare
skjnldsv
added
the
4. to release
skjnldsv
force-pushed
the
feat/theming-scheme-meta
branch
from
4e2b616
to
9c9579a
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com> Signed-off-by: Simon L <szaimen@e.mail.de>
skjnldsv
force-pushed
the
feat/theming-scheme-meta
branch
from
9c9579a
to
775974f
Compare
artonge
pushed a commit
that referenced
this pull request
Feb 8, 2024
Merged
|
This PR changes
I have a dark system theme and a light Nextcloud theme. With this PR, I have <meta name="color-scheme" content="light dark">Is With
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://html.spec.whatwg.org/multipage/semantics.html#meta-color-scheme