don't hard error when trying to load profiles with no profiler registered #33292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991 please always make sure to have 4-5 reviewers lined up to increase the probability |
Merged
icewind1991
force-pushed
the
no-profiler
branch
from
7d066bf
to
f01f42c
Compare
icewind1991
requested review from
a team,
blizzz and
juliushaertl
and removed request for
a team
Merged
Merged
Merged
…ered Signed-off-by: Robin Appelman <robin@icewind.nl>
come-nc
approved these changes
Apr 5, 2023
Comment on lines
+64
to
+68
| if ($this->storage) { | ||
| return $this->storage->read($token); | ||
| } else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ($this->storage) { | |
| return $this->storage->read($token); | |
| } else { | |
| return null; | |
| } | |
| return $this->storage?->read($token); |
For the record, you can use the nullsafe operator in PHP 8 for this.
juliushaertl
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead just return empty results