Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plsam taint analysis baseline #33779

Closed
wants to merge 1 commit into from
Closed

Conversation

CarlSchwan
Copy link
Member

And remove some false positive

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 31, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 31, 2022
@CarlSchwan CarlSchwan self-assigned this Aug 31, 2022
@blizzz blizzz mentioned this pull request Sep 1, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
And remove some false positive

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -56,6 +56,7 @@ public function __construct(
* @return JSONResponse
*/
public function create(string $layout): JSONResponse {
$layout = htmlspecialchars($layout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention this in your commit message? 😅

@come-nc come-nc assigned come-nc and unassigned CarlSchwan Jan 24, 2023
@come-nc
Copy link
Contributor

come-nc commented Jan 24, 2023

Assigning that to me, the taint analysis is already done in an other job, but the docblock and escaping fixes from this PR should still be merged.

@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

conflicts :/

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2023
@come-nc
Copy link
Contributor

come-nc commented Apr 24, 2023

Replaced by #36378 for the relevant parts.

@come-nc come-nc closed this Apr 24, 2023
@szaimen szaimen deleted the psalm-taint-escape branch April 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants