Fix FFMPEG preview manager #34161
Merged
Fix FFMPEG preview manager #34161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
J0WI,
a team,
PVince81,
ArtificialOwl and
come-nc
and removed request for
a team
|
/backport to stable24 |
|
/backport to stable23 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/fix-ffmpeg-preview-manager
branch
from
0c66977
to
efedb21
Compare
blizzz
approved these changes
Sep 20, 2022
nickvergessen
added
bug
3. to review
CarlSchwan
approved these changes
Sep 20, 2022
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
Closed
|
Linked to the wrong pull request, Regression is from #33593 So only 25+ and no backport needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #26531
findBinaryPathreturns false instead of null, so the second options where never tested