Changed mapping to font #34419
Merged
Changed mapping to font #34419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
juliushaertl
requested changes
Oct 4, 2022
|
@jancborchardt Maybe you can come up with a nice icon for font files? |
|
Yes, |
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
* Updated mimetypelist icon mapping Signed-off-by: Dany1718 <daniel.dossantos@ufl.edu>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team,
susnux,
artonge,
Pytal and
juliushaertl
and removed request for
a team
|
I rebased the PR and pushed a commit providing the icon @jancborchardt suggested, it looks like this now:
|
susnux
approved these changes
Aug 3, 2023
Fenn-CS
approved these changes
Aug 3, 2023
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
The failing CheckerTest looks related
|
|
Fix: #39705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code had "application/font-woff": "image"
which caused the error.
New code has fixed the mapping.