Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text/asciidoc mimetype #35176

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

bjornfor
Copy link
Contributor

Ref https://docs.asciidoctor.org/asciidoc/latest/faq/#whats-the-media-type-aka-mime-type-for-asciidoc

This is step 1 towards allowing editing of AsciiDoc files in Nextcloud.
Step 2 is adding support in https://github.com/nextcloud/text.

Signed-off-by: Bjørn Forsman bjorn.forsman@gmail.com

Ref https://docs.asciidoctor.org/asciidoc/latest/faq/#whats-the-media-type-aka-mime-type-for-asciidoc

This is step 1 towards allowing editing of AsciiDoc files in Nextcloud.
Step 2 is adding support in https://github.com/nextcloud/text.

Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
@bjornfor
Copy link
Contributor Author

I based this on nextcloud/text#394 (comment). Untested.

@szaimen szaimen added this to the Nextcloud 26 milestone Nov 15, 2022
@szaimen szaimen added the 3. to review Waiting for reviews label Nov 15, 2022
@bjornfor
Copy link
Contributor Author

The performance testing check failed like this:

Run git fetch origin add-asciidoc-mime-type
fatal: couldn't find remote ref add-asciidoc-mime-type
Error: Process completed with exit code 128.

I don't know what I can do about that.

@juliushaertl juliushaertl requested review from a team, skjnldsv and CarlSchwan and removed request for a team December 7, 2022 19:52
@CarlSchwan CarlSchwan merged commit 7ac2d31 into nextcloud:master Dec 7, 2022
@welcome
Copy link

welcome bot commented Dec 7, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants