Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @nextcloud/vue to 7.1.0-beta0 #35179

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Bump @nextcloud/vue to 7.1.0-beta0 #35179

merged 2 commits into from
Nov 15, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 15, 2022 •
edited
Loading

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Nov 15, 2022
@skjnldsv skjnldsv requested review from PVince81 and a team November 15, 2022 13:46
@skjnldsv skjnldsv self-assigned this Nov 15, 2022
@skjnldsv skjnldsv requested review from artonge and Pytal and removed request for a team November 15, 2022 13:47
PVince81
PVince81 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@skjnldsv skjnldsv mentioned this pull request Nov 15, 2022
Merged
szaimen
szaimen approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some small testing and can confirm #34777 and #33839 get fixed by it :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 15, 2022 •
edited
Loading

/compile amend /

Won't work, this needs nextcloud/calendar-availability-vue#29
Assets are already shipped here

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

Won't work, this needs nextcloud/calendar-availability-vue#29
Assets are already shipped here

yeah, noticed directly after posting the comment

@skjnldsv
Bump @nextcloud/vue to 7.1.0-beta0
7cc6f63 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the dependaskjnldsv/nextcloud-vue branch from 007d528 to 7cc6f63 Compare November 15, 2022 17:51
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2022
@skjnldsv
Copy link
Member Author

Rebased, compiled and upgraded. let's go 🚀

@skjnldsv
Copy link
Member Author

/backport to stable25

@skjnldsv
Fix CalDavSettings spec
d78fa59 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@Pytal Pytal merged commit 968a411 into master Nov 15, 2022
@Pytal Pytal deleted the dependaskjnldsv/nextcloud-vue branch November 15, 2022 19:13
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Nov 15, 2022 •
edited by Pytal
Loading

The backport to stable25 failed. Please do this backport manually.

#35188

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

@Pytal can you take care of this? :)

@Pytal Pytal mentioned this pull request Nov 15, 2022
Merged
@Pytal
Copy link
Member

Pytal commented Nov 15, 2022

@Pytal can you take care of this? :)

Please review #35188 :)

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

Thanks and done :)

@Pytal Pytal mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
None yet
Milestone
No milestone
5 participants
@skjnldsv @szaimen @Pytal @PVince81 @artonge