-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable25] Revert "[stable25] Fix border color contrast" #35454
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
Mind adding a reason for the revert? |
See the disscussion in the engineering chat. |
the chat is not available for the public the reason is: 25.0.2 RC1 is out and causes a regression in some apps. I'll leave this PR open until we get the feedback from @Pytal later today, if the proper fix is indeed not trivial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as discussed
up to @Pytal to merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me if a revert is needed quickly. After that an ideal fix would be with an extra variable as said in the issue. :)
Discussion with design team and accessibility reviewer will be tracked in #35457 |
Workaround for #35457 to not block 25.0.2
Signed-off-by: Simon L szaimen@e.mail.de
Tested with: