Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new border color variable and adjust primary color for increased contrast #35549

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Add new border color variable and adjust primary color for increased contrast #35549

merged 2 commits into from
Dec 6, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 2, 2022 •
edited
Loading

Add a new CSS variable instead of changing the existing ones so developers can explicitly opt-in to using this border color with increased contrast

Dark mode (--color-border-maxcontrast): #646464
Light mode (--color-border-maxcontrast): #949494

Also lighten the original primary color slightly #00639a → #006aa3 for increased contrast

@Pytal Pytal added this to the Nextcloud 26 milestone Dec 2, 2022
@Pytal Pytal self-assigned this Dec 2, 2022
@Pytal
Copy link
Member Author

Pytal commented Dec 2, 2022

/backport to stable25

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chosen contrast should be fine. Thanks you!

@Pytal Pytal mentioned this pull request Dec 3, 2022
Merged
@Pytal Pytal marked this pull request as draft December 3, 2022 00:59
@Pytal
Copy link
Member Author

Pytal commented Dec 3, 2022

Revert #35563 must go in first after discussions with @skjnldsv for cleaner git history

@Pytal Pytal changed the title Add new border color variable for increased contrast instead of changing decorative border colors Add new border color variable for increased contrast Dec 3, 2022
@Pytal
Add new border color variable for increased contrast
24ffe32 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Lighten default color slightly for increased contrast
1c753c2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal changed the title Add new border color variable for increased contrast Add new border color variable and adjust primary color for increased contrast Dec 6, 2022
@Pytal Pytal marked this pull request as ready for review December 6, 2022 01:20
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2022
@Pytal Pytal merged commit badf09b into master Dec 6, 2022
@Pytal Pytal deleted the enh/a11y-contrast-borders branch December 6, 2022 02:14
@Pytal
Copy link
Member Author

Pytal commented Dec 6, 2022

/backport to stable25

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 7, 2022 •
edited by Pytal
Loading

The backport to stable25 failed. Please do this backport manually.

#35640

@Pytal Pytal mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility regression
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @AndyScherzinger @JuliaKirschenheuter @skjnldsv