-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default redirect on successful WebAuthn login #35604
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
This might be an old bug. Before #34662 we'd still redirect to the default page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
CI failure unrelated |
Ahh, that would explain why it was broken but nobody noticed until recently. |
The backport to stable25 failed. Please do this backport manually. |
The backport to stable24 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
/backport to stable25 |
This was only a problem in master so no need for backports |
A quick search didn't show a related ticket but there might be some.
Summary
A user is redirected to
/false
after logging in succesfully when no redirect url parameter is specified. I added a default url as a fallback.Before
The user is redirected to the page specified via the
redirect_url
parameter. If it isn't set, the user is redirected to/false
.After
The user is redirected to the page specified via the
redirect_url
parameter. If it isn't set, the user is redirected to the configured default page.TODO
Checklist