Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust branding of errorlog log messages #35612

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 5, 2022

Resolves: N/a

Summary

Welcome to 2022.

Let's not backport this because admins might use the tag to filter their logs. I will update the admin docs to mention this.

TODO

  • Do

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Dec 5, 2022
@ChristophWurst ChristophWurst self-assigned this Dec 5, 2022
@ChristophWurst ChristophWurst changed the title chore(logging): Fix branding of errorlog log messages Adjust branding of errorlog log messages Dec 5, 2022
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen added this to the Nextcloud 26 milestone Dec 5, 2022
@ChristophWurst
Copy link
Member Author

Doc update at nextcloud/documentation#9467

@szaimen
Copy link
Contributor

szaimen commented Dec 6, 2022

@ChristophWurst should we also add this to #34692?

@ChristophWurst
Copy link
Member Author

@ChristophWurst should we also add this to #34692?

That ticket is just a collection of topics that have to be documented. Since I already did the docs, it's kind of superfluous.

@szaimen
Copy link
Contributor

szaimen commented Dec 6, 2022

Fine by me then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

3 participants