Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle reminders where calendar name is null #36217

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Handle reminders where calendar name is null #36217

merged 1 commit into from
Apr 17, 2023

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Jan 18, 2023 •
edited
Loading

This adds an interface change, but that's not a public API. Backports should be acceptable, unless the new string to translate is not.

We're handling this in the providers and not in ReminderService because the fallback is translated with the user's language.

Checklist

@tcitworld tcitworld added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Jan 18, 2023
@tcitworld tcitworld added this to the Nextcloud 26 milestone Jan 18, 2023
@tcitworld tcitworld requested a review from a team January 18, 2023 13:28
@tcitworld tcitworld self-assigned this Jan 18, 2023
@tcitworld
Handle reminders where calendar name is null
62739ec 
This adds an interface change, but that's not a public API.

We're handling this in the providers and not in ReminderService because
the fallback is translated with the user's language.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the handle-push-notification-with-no-calendar-name branch from 4dc068b to 62739ec Compare January 18, 2023 13:30
@tcitworld
Copy link
Member Author

/backport to stable25

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

Drone failure unrelated

@szaimen szaimen merged commit e63720b into master Apr 17, 2023
@szaimen szaimen deleted the handle-push-notification-with-no-calendar-name branch April 17, 2023 13:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 17, 2023
Merged
1 task
@tcitworld
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@tcitworld tcitworld

Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
6 participants
@tcitworld @szaimen @ChristophWurst @miaulalala @come-nc @blizzz